Sheffield| 26-ITP-Jan| Mona-Eltantawy | Sprint 2 | Coursework/sprint 2#1227
Open
Mona-Eltantawy wants to merge 17 commits intoCodeYourFuture:mainfrom
Open
Sheffield| 26-ITP-Jan| Mona-Eltantawy | Sprint 2 | Coursework/sprint 2#1227Mona-Eltantawy wants to merge 17 commits intoCodeYourFuture:mainfrom
Mona-Eltantawy wants to merge 17 commits intoCodeYourFuture:mainfrom
Conversation
…syntax error occurs when the program runs and write the new code that doesn't redeclare the decimalNumber in a const variable in inside the function
…e the function paramater name is unvaild number . and changed the code after trying it by changing the function name to num be decalred and to work when I call the function.
… return a value and changed the console.log inside the function into return instead.
…return statement comes befor the value a +b and changed it to the correct order.
…amater to the getLastDigit function to make it accept new paramaters when it's called.
…underscores using the .toUpperCase() and 'replace' functions.
…ing and added a return at the end of the function.
…n of the str identifier and this what happened when i tested the programe. I suggested to change the let variable name into an new name 'newStr' and this fixed the issue.
Mona-Eltantawy
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Mar 11, 2026
cjyuan
added
Reviewed
…erting the string from tofix() back to a number by using Numbe
Mona-Eltantawy
added
the
Needs Review
cjyuan
reviewed
Mar 18, 2026
Comment on lines
+19
to
+23
| when the program run it give a SyntaxError: Identifier 'decimalNumber' has already been declared. This is because the variable decimalNumber is declared twice in the function | ||
| convertToPercentage. | ||
| Also using the function name decimalNumber with the console.log function will give an error because the function name should be a prober name not a Number. | ||
| to fix this error we can remove the const variable declaration of decimalNumber from the function and use the function name | ||
| 'ConvertToPercentage' to recall the function and pass the value of the decimalNumber declaration |
Contributor
There was a problem hiding this comment.
Should you need to keep them as comment (so Prettier won't identify them as invalid code), you can add // at the start of each line.
cjyuan
removed
Needs Review
cjyuan
added
the
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I did the required changes for the Sprint 2 key -errors, mandatory-debug, mandatory- implement and mandatory- interpret files. committed the changes and pushed it to the git branch.